Skip to content

Sjw/guid fix#12

Merged
swernli merged 2 commits into
masterfrom
sjw/guid_fix
Jul 22, 2015
Merged

Sjw/guid fix#12
swernli merged 2 commits into
masterfrom
sjw/guid_fix

Conversation

@swernli
Copy link
Copy Markdown
Contributor

@swernli swernli commented Jul 21, 2015

Final set of changes to update use of NameToGuid and GUID.ToString for bug fix.

swernli added 2 commits July 21, 2015 13:15
@swernli
Changing layerutils to use new hcsshim guid hashing function.
7d7fbd2 
Signed-off-by: Stefan J. Wernli <swernli@microsoft.com>
@swernli
Fixing GUID.ToString to use correct endian-ness.
64b66f5 
Signed-off-by: Stefan J. Wernli <swernli@microsoft.com>
@msftclas
Copy link
Copy Markdown

msftclas commented Jul 21, 2015

Hi @swernli, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Stefan Wernli). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@lowenna
Copy link
Copy Markdown
Contributor

lowenna commented Jul 22, 2015

LGTM

swernli added a commit that referenced this pull request Jul 22, 2015
@swernli
Merge pull request #12 from Microsoft/sjw/guid_fix
236c434 
Sjw/guid fix
@swernli swernli merged commit 236c434 into master Jul 22, 2015
@swernli
Copy link
Copy Markdown
Contributor Author

swernli commented Jul 22, 2015

I also went ahead and reassigned the bug to you. The corresponding docker changes are in github.com/Microsoft/docker/sjw/guid_fix.

From: John Howard (Microsoft) [mailto:notifications@github.com]
Sent: Tuesday, July 21, 2015 5:01 PM
To: Microsoft/hcsshim
Cc: Stefan Wernli
Subject: Re: [hcsshim] Sjw/guid fix (#12)

LGTM

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12#issuecomment-123512619.

dcantah pushed a commit to dcantah/hcsshim that referenced this pull request Mar 17, 2021
@jterry75
Fixes the majority of golint issues
a618cc5 
Partial: microsoft#12
dcantah pushed a commit to dcantah/hcsshim that referenced this pull request Mar 17, 2021
@jterry75
Fixes a golint issue
ca946d5 
Resolves: microsoft#12
johnsonshih pushed a commit to nagiesek/hcsshim that referenced this pull request Apr 1, 2022
@jagadishmurugan
Query for specific network instead of enumerating all networks and fi… (
9ee216c 
microsoft#12)

* Query for specific network instead of enumerating all networks and filtering. DefaultSwitch is created when hcnOpenNetwork is called for the first time

* remove redundant check
kiashok added a commit to kiashok/hcsshim that referenced this pull request Jan 28, 2025
@kiashok
Merge pull request microsoft#12 from MahatiC/kirtana/local-bridge-sid…
6f38cf7 
…ecar-outside-uvm

gcs-sidecar: Code cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swernli @msftclas @lowenna